3D FPGA block select fix, and rr-node display fix for 3D FPGAs #2380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd updated routing nets to fix a bug for cross-level connections transparency
…-layered fpgas, Blocks on higher levels are prioritized during instances of overlap between blocks of different layers.
Make format command
vaughnbetz
requested changes
Aug 30, 2023
vaughnbetz
changed the title
…ked on by the user and added comments to the function in the .h file.
ran the make format command
… visible layers are checked for hits to ensure that we only highlight nodes that are on visible layers.
Meet-Patel2580
commented
Sep 3, 2023
vpr/src/draw/draw_rr.cpp
Outdated
There was a problem hiding this comment.
highlighting of RR nodes has just been changed to ensure that only nodes on currently visible layers are checked to determine whether they should be highlighted or not. This fixes the bug of the user clicking on a node, but not seeing it highlight due to the code mistakenly changing the highlight setting for a node on an invisible layer.
vaughnbetz
reviewed
Sep 6, 2023
|
@Meet-Patel2580 : are the clicked x,y coordinates in world coordinates? If so we should comment that; I think after that it can be merged. |
Changes in comments
|
Looks good; can be merged as soon as CI finishes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes